Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v1): showcase user Jafar #2242

Merged
merged 4 commits into from
Jan 24, 2020
Merged

docs(v1): showcase user Jafar #2242

merged 4 commits into from
Jan 24, 2020

Conversation

galhavivi
Copy link
Contributor

Add Jafar to users

https://yahoo.github.io/jafar/

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@galhavivi galhavivi requested a review from yangshun as a code owner January 24, 2020 17:28
@facebook-github-bot
Copy link
Contributor

Hi galhavivi! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 24, 2020

Deploy preview for docusaurus-2 ready!

Built with commit d347889

https://deploy-preview-2242--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 24, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title Add Jafar to users docs(v1): showcase user Jafar Jan 24, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cute! Thanks for adding!

@yangshun yangshun merged commit a50c38b into facebook:master Jan 24, 2020
@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants